Repository navigation
Conversation
1e5f341 to
18674dc
Compare
tartarughina
left a comment
There was a problem hiding this comment.
I'll have to test properly the behavior but something to be called out is the runtime injection for the test runner. I need to double check but it might not work as everything needs to be downloaded before JDTLS starts. This would mean that just on the first trial the runner won't be recognized by JDTLS.
| let host = Path::new(&launcher) | ||
| .canonicalize() | ||
| .ok() | ||
| .and_then(|path| path.parent()?.parent().map(Path::to_path_buf)) | ||
| .filter(|path| path.join("plugins").is_dir()); |
There was a problem hiding this comment.
I'm not a fan of this path traversal, it looks brittle
| pub program_arguments: Vec<String>, | ||
| } | ||
|
|
||
| impl TestTarget { |
There was a problem hiding this comment.
Let's add some whitespace to split related portions of the code. A wall of text even in the world of agents is tough to go through
| } else { | ||
| class | ||
| }; | ||
| if !(0..=3).any(|kind| is_level(&item.test_kind, kind)) { |
There was a problem hiding this comment.
Should we add a comment explaining the reason for the iteration from 0 to 3?
There was a problem hiding this comment.
As done for jdtls, the debugger and in general whenever in need of downloading something, please implement the trait Downloadable
There was a problem hiding this comment.
If this is based on the VS Code implementation, then please add a comment pointing to that
Refs #329. This follows #330, which added gutter debugging for Java main methods.
Changes
testTargetfrom the selected gutter task and defer test discovery and compilation until launch. The pinned Microsoft Java Test Runner is downloaded and loaded into JDTLS on demand.Verification